Consolidate events between EventConstants and BrowserEventEmitter #9512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophiebits
approved these changes
Apr 24, 2017
docs/js/react-dom.js
Outdated
| @@ -350,7 +350,7 @@ function extractCompositionEvent(topLevelType, targetInst, nativeEvent, nativeEv | |||
| } | |||
|
|
|||
| /** | |||
| * @param {string} topLevelType Record from `EventConstants`. | |||
There was a problem hiding this comment.
can you revert this file?
|
|
||
| var getVendorPrefixedEventName = require('getVendorPrefixedEventName'); | ||
|
|
||
| export type PropagationPhases = 'bubbled' | 'captured'; |
There was a problem hiding this comment.
Rollover from EventConstants. Happy to remove though.
There was a problem hiding this comment.
Ah right, it gets referenced here: https://github.com/facebook/react/pull/9512/files#diff-1ca53ffa4da75a64f7c3b2f131f62da7R21
There was a problem hiding this comment.
Let's just move it to that file.
nhunzaker
force-pushed
the
consolidate-events
branch
from
eef542a to
1c00c12
Compare
|
I think everything should be good to go. Struggling with CI however. Any ideas? |
Does moving the file to src/renderers/dom/shared/event/BrowserEventConstants.js fix the issue? That is where it should be anyway. |
This is a follow up to facebook#9333. This commit removes some duplication of event names and renames the EventConstants module to BrowserEventConstants.
Fixes an issue during build.
nhunzaker
force-pushed
the
consolidate-events
branch
from
b8c7a63 to
31e8988
Compare
|
@spicyj Hey, that did it! I just upstreamed from master, but looks like that was it! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to the request made by @spicyj in #9333. This commit removes some duplication of event names by consolidating them into the EventConstants module. It then renames that module to BrowserEventConstants.